Project

General

Profile

Actions
Copy link

Refactor #30127

closed

Refactor #30581: Extract fact importing from Host class to to HostFactImporter

Extract import_facts entry point from host class and create HostFactImporter

Added by Ondřej Ezr over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Ezr
Category:
Facts
Target version:
-
Difficulty:
medium
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/7883, https://github.com/theforeman/foreman/pull/7749
Fixed in Releases:
2.2.0
Found in Releases:
Red Hat JIRA:

Description

The fact import is now tied with a Host model. We might want to extract it as the clas is too big and it should not be its responsibility.

Related issues 4 (1 open — 3 closed)

Related to Foreman - Tracker #30128: Remove STI from Host modelNew

Actions
Related to Discovery - Bug #30577: Tests fail due to HostFactImporter#import_factsClosedLukas ZapletalActions
Related to Foreman - Bug #31364: undefined method `without_orchestration'ClosedTomer BriskerActions
Related to Foreman - Refactor #34063: Remove the deprecated Host#import_facts methodClosedTomer BriskerActions
Actions
Copy link
 #1

Updated by Ondřej Ezr over 4 years ago

Actions
Copy link
 #2

Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ondřej Ezr
  • Pull request https://github.com/theforeman/foreman/pull/7749 added
Actions
Copy link
 #3

Updated by Lukas Zapletal over 4 years ago

  • Related to Bug #30577: Tests fail due to HostFactImporter#import_facts added
Actions
Copy link
 #4

Updated by Ondřej Ezr over 4 years ago

  • Subject changed from Extract fact import from host class to Extract import_facts entry point from host class and create HostFactImporter
  • Parent task set to #30581
  • Difficulty set to medium
  • Triaged changed from No to Yes
Actions
Copy link
 #5

Updated by The Foreman Bot over 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/7883 added
Actions
Copy link
 #6

Updated by The Foreman Bot over 4 years ago

  • Fixed in Releases 2.2.0 added
Actions
Copy link
 #7

Updated by Ondřej Ezr over 4 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #8

Updated by The Foreman Bot about 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/7975 added
Actions
Copy link
 #9

Updated by Tomer Brisker about 4 years ago

  • Related to Bug #31364: undefined method `without_orchestration' added
Actions
Copy link
 #10

Updated by Tomer Brisker about 3 years ago

  • Related to Refactor #34063: Remove the deprecated Host#import_facts method added
Actions
Copy link

Also available in: Atom PDF