Project

General

Profile

Bug #31436

Re-enable disabled Rubocop cops that were turned off when fixing Rubocop Jenkins failure step

Added by Chris Roberts over 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Jeremy Lenz
Category:
Tooling
Target version:
Katello 4.4.0
Difficulty:
medium
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/9831
Fixed in Releases:
Katello 4.4.0
Found in Releases:
Katello 3.18.0
Red Hat JIRA:

Description

The following cops in Rubocop were disabled so we could get passed the failing Jenkins step:

rubocop `Style/MethodMissingSuper` cop has been removed since it has been superseded by `Lint/MissingSuper`

Minitest/GlobalExpectations:
Enabled: false

Performance/CollectionLiteralInLoop:
Enabled: false

Rails/RedundantForeignKey:
Enabled: false

Rails/UniqueValidationWithoutIndex:
Enabled: false

Related to https://projects.theforeman.org/issues/31422

Related issues

Has duplicate Katello - Bug #34056: Re-enable disabled Rubocop cops that were turned off when fixing Rubocop Jenkins failure stepClosed

Associated revisions

Revision 89230c54 (diff)
Added by Jeremy Lenz 5 months ago

Fixes #31436 - Clean duplicate table rows & re-enable disabled Rubocops (#9831)

  • Fixes #31436 - Clean duplicate table rows & re-enable disabled Rubocops
  • Refs #31436 - re-enable rules and run auto-correct
  • Refs #31436 - don't reenable Performance/CollectionLiteralInLoop
  • Refs #31436 - add DeduplicationMigrator class & tests
  • Refs #31436 - GlobalExpectations manual fix
  • Refs #31436 - fix action_planed typo
  • Refs #31436 - add error =
  • Refs #31436 - fix pool_service_test
  • Refs #31436 - fix assert_not

History

#1 Updated by Chris Roberts over 1 year ago

  • Triaged changed from No to Yes

#2 Updated by Chris Roberts over 1 year ago

  • Target version changed from Katello 4.0.0 to Katello 4.1.0

#3 Updated by Chris Roberts about 1 year ago

  • Target version changed from Katello 4.1.0 to Katello 4.2.0

#4 Updated by Chris Roberts 10 months ago

  • Target version changed from Katello 4.2.0 to Katello 4.3.0

#5 Updated by Chris Roberts 6 months ago

  • Target version changed from Katello 4.3.0 to Katello 4.4.0

#6 Updated by Jonathon Turel 6 months ago

  • Has duplicate Bug #34056: Re-enable disabled Rubocop cops that were turned off when fixing Rubocop Jenkins failure step added

#7 Updated by The Foreman Bot 5 months ago

  • Assignee set to Jeremy Lenz
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/9831 added

#8 Updated by Jeremy Lenz 5 months ago

  • Subject changed from Renable disabled Rubocop cops that were turned off when fixing Rubocop Jenkins failure step to Re-enable disabled Rubocop cops that were turned off when fixing Rubocop Jenkins failure step

#9 Updated by The Foreman Bot 5 months ago

  • Fixed in Releases Katello 4.4.0 added

#10 Updated by Jeremy Lenz 5 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF