Project

General

Profile

Actions

Bug #31436

closed

Re-enable disabled Rubocop cops that were turned off when fixing Rubocop Jenkins failure step

Added by Chris Roberts over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tooling
Target version:
Difficulty:
medium
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

The following cops in Rubocop were disabled so we could get passed the failing Jenkins step:

rubocop `Style/MethodMissingSuper` cop has been removed since it has been superseded by `Lint/MissingSuper`

Minitest/GlobalExpectations:
Enabled: false

Performance/CollectionLiteralInLoop:
Enabled: false

Rails/RedundantForeignKey:
Enabled: false

Rails/UniqueValidationWithoutIndex:
Enabled: false

Related to https://projects.theforeman.org/issues/31422


Related issues 1 (0 open1 closed)

Has duplicate Katello - Bug #34056: Re-enable disabled Rubocop cops that were turned off when fixing Rubocop Jenkins failure stepClosedActions
Actions #1

Updated by Chris Roberts over 3 years ago

  • Triaged changed from No to Yes
Actions #2

Updated by Chris Roberts over 3 years ago

  • Target version changed from Katello 4.0.0 to Katello 4.1.0
Actions #3

Updated by Chris Roberts about 3 years ago

  • Target version changed from Katello 4.1.0 to Katello 4.2.0
Actions #4

Updated by Chris Roberts almost 3 years ago

  • Target version changed from Katello 4.2.0 to Katello 4.3.0
Actions #5

Updated by Chris Roberts over 2 years ago

  • Target version changed from Katello 4.3.0 to Katello 4.4.0
Actions #6

Updated by Jonathon Turel over 2 years ago

  • Has duplicate Bug #34056: Re-enable disabled Rubocop cops that were turned off when fixing Rubocop Jenkins failure step added
Actions #7

Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Jeremy Lenz
  • Pull request https://github.com/Katello/katello/pull/9831 added
Actions #8

Updated by Jeremy Lenz over 2 years ago

  • Subject changed from Renable disabled Rubocop cops that were turned off when fixing Rubocop Jenkins failure step to Re-enable disabled Rubocop cops that were turned off when fixing Rubocop Jenkins failure step
Actions #9

Updated by The Foreman Bot over 2 years ago

  • Fixed in Releases Katello 4.4.0 added
Actions #10

Updated by Jeremy Lenz over 2 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF