Bug #31751: The default kickstart template installs EPEL by default - Foreman

Actions

Copy link

Bug #31751

closed

The default kickstart template installs EPEL by default

Added by Marek Hulán about 3 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Evgeni Golov

Category:

Templates

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/8295

Fixed in Releases:

3.0.0

Found in Releases:

Red Hat JIRA:

Description

Since Foreman 2.1 (thanks to #28070) if the enable-epel parameter is not set, the default kickstart template will still install the epel. This is due to

<% if rhel_compatible && !host_param_false?('enable-epel') -%>
<%= snippet 'epel' -%>
<% end -%>

https://github.com/theforeman/foreman/blob/4ff6f0a1f0b8c6227f91e6b2bcd5c33e00b22a18/app/views/unattended/provisioning_templates/provision/kickstart_default.erb#L278-L280

The problem is, host_param_false?('enable-epel') returns false in case the parameter is not found (the default value, optional second parameter). Then it's negated to true. This change was introduced in the mentioned #28070

In this ticket, we should

1) switch the default value of host_param_false? to true, like suggested in the original PR https://github.com/theforeman/foreman/pull/7110#discussion_r335387999 (the same for host_param_true?)

2) modify the template to use host_param_true?('enable-epel') and stop doing double negation

3) optionally I'd consider seeding this parameter with the default value false, so people would know, they can actually set/override it

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Marek Hulán about 3 years ago

Related to Bug #28070: Fallback default value for host_param_XXX? macros added

Actions

Copy link

Updated by Evgeni Golov about 3 years ago

FWIW, enable-epel was added in community templates back in 2016:

commit 22f430d42a23f2c2316d990da6a56638c6fc1c84
Author: Alex Fisher <alex@linfratech.co.uk>
Date:   Sat Apr 23 16:57:40 2016 +0100

    Add enable-epel param (#266)

    Defaults to true, but provides a way to disable the use of EPEL repos.

and is supposed to default to "true", so using !host_param_false?('enable-epel') is correct from a backwards compatibility standpoint of the template (I'd disagree that we should enable epel by default, but that's a totally different discussion).

However, the default value of host_param_false? should really be true…

Actions

Copy link