Actions
Bug #33106
closed
Move more variables from in puppet-foreman to globals.pp
Status:
Closed
Priority:
Normal
Assignee:
Category:
Foreman modules
Target version:
-
Difficulty:
Triaged:
No
Description
from https://github.com/theforeman/puppet-foreman/pull/974#pullrequestreview-711530448
As for other variables:
- version & plugin_version - I can still see a use case so I'm not entirely sure.
- user & group - these are hardly ever changed so I'd be in favor of moving them
- rails_env & app_root same
- vhost_priority same (perhaps even move it to apache.pp and only allow changing it via Hiera)
Updated by Evgeni Golov over 2 years ago
- Related to Bug #33089: Don't store plugin_prefix (and hammer_plugin_prefix) in answers added
Updated by The Foreman Bot over 2 years ago
- Status changed from New to Ready For Testing
- Assignee set to Ewoud Kohl van Wijngaarden
- Pull request https://github.com/theforeman/puppet-foreman/pull/975 added
Updated by Ewoud Kohl van Wijngaarden over 2 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset puppet-foreman|0e45f2055787dd9c42afc2e431c45ab45630b4b5.
Updated by
Actions