Project

General

Profile

Bug #33106

Move more variables from in puppet-foreman to globals.pp

Added by Evgeni Golov 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Foreman modules
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

from https://github.com/theforeman/puppet-foreman/pull/974#pullrequestreview-711530448

As for other variables:

  • version & plugin_version - I can still see a use case so I'm not entirely sure.
  • user & group - these are hardly ever changed so I'd be in favor of moving them
  • rails_env & app_root same
  • vhost_priority same (perhaps even move it to apache.pp and only allow changing it via Hiera)

Related issues

Related to Installer - Bug #33089: Don't store plugin_prefix (and hammer_plugin_prefix) in answersClosed

Associated revisions

Revision 0e45f205 (diff)
Added by Ewoud Kohl van Wijngaarden 3 months ago

Fixes #33106 - Move user, app_root, rails_env & vhost_prio to globals

These parameters are not commonly changed. Moving them to globals makes
the list of parameters in init.pp shorter and easier to manage. This
is of particular benefit in the installer while it shouldn't hinder
users of the module in a pure Puppet environment too much.

History

#1 Updated by Evgeni Golov 3 months ago

  • Related to Bug #33089: Don't store plugin_prefix (and hammer_plugin_prefix) in answers added

#2 Updated by The Foreman Bot 3 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/puppet-foreman/pull/975 added

#3 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 3.0.0 added

#4 Updated by Ewoud Kohl van Wijngaarden 3 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Amit Upadhye 2 months ago

  • Category set to Foreman modules

Also available in: Atom PDF