Project

General

Profile

Bug #4227

Override Parameter not saved in Host

Added by Yama Kasi over 5 years ago. Updated over 5 years ago.

Status:
Duplicate
Priority:
High
Assignee:
-
Category:
Host creation
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

When you have a host and want to override a Class Parameter and submit it it's not saved.

If you edit this parameter, Submit it and go back to edit, the set parameter is gone and set back to the list of possible overrides.

override_host_param_production.txt override_host_param_production.txt 5.7 KB Yama Kasi, 02/03/2014 02:27 PM
Production_2.txt Production_2.txt 115 KB Yama Kasi, 02/04/2014 02:44 PM

Related issues

Related to Foreman - Bug #4234: Cannot edit host's puppet parametersClosed2014-02-03

History

#1 Updated by Dominic Cleal over 5 years ago

  • Legacy Backlogs Release (now unused) deleted (2)
  • Difficulty deleted (easy)

#2 Updated by Greg Sutcliffe over 5 years ago

  • Status changed from New to Need more information

I can't replicate this - I can override default class parameters at the host level with no issues. Can you provide more information please? Are you using validators on the class parameter? Do you have any logs showing errors on save?

#3 Updated by Yama Kasi over 5 years ago

I don't see errors on saving, a 302, but this should be OK.

My validators are emtpy and I have seen this same issue on 1.3.2 on the puppetclasses itself, this is fixed in 1.4. On 1.3.2 host overrides were working, but not anymore on 1.4.

So it seems that the issue has moved.

#4 Updated by Yama Kasi over 5 years ago

I have found out that Global Paramaters (manually) created for a group are saved.

#5 Updated by Yama Kasi over 5 years ago

I have checked the following:

It seems that override paramaters (from a group or not) are not inserted into the database following the PgSQL logs.

A global parameter is inserted or updated following the pgSQL logs.

#6 Updated by Dominic Cleal over 5 years ago

Please provide debug logs when updating the host: http://projects.theforeman.org/projects/foreman/wiki/Troubleshooting#How-do-I-enable-debugging

Not setting the release - that's indicative of the version it's been fixed in.

#7 Updated by Yama Kasi over 5 years ago

I have added a log when I submit a override, I know how to enable debugging ;)

#8 Updated by Yama Kasi over 5 years ago

OK, I have checked everything double and am not able to see where this goes wrong.

It's a bug fore sure, we just need to debug out where and why it exists.

#9 Updated by Yama Kasi over 5 years ago

Hereby a new log with full logging after my reinstall of the foreman package.

This log only contains a submit of override paramater that was already filled in on a host but not saved/set yet.

#10 Updated by Yama Kasi over 5 years ago

Is here still more information needed ?

FM is useless here at the moment.

#11 Updated by Dominic Cleal over 5 years ago

  • Related to Bug #4234: Cannot edit host's puppet parameters added

#12 Updated by Dominic Cleal over 5 years ago

  • Status changed from Need more information to New

I suspect this might be #4234, since I see in the debug log:

\f1\b \cf3 LookupValue Exists (1.0ms)
\f0\b0 \cf0 SELECT 1 AS one FROM "lookup_values" WHERE ("lookup_values"."match" = 'fqdn=mysql-01' AND "lookup_values"."lookup_key_id" = 742) LIMIT 1\
\f1\b \cf3 LookupValue Load (0.8ms)
\f0\b0 \cf0 SELECT "lookup_values".* FROM "lookup_values" WHERE "lookup_values"."match" = 'fqdn=mysql-01.domain.local'\

The lookup should always be for the FQDN, not the shortname.

It would only affect fully-managed hosts, due to a separate domain being set.

#13 Updated by Yama Kasi over 5 years ago

That is very right Dominic, I have seen the same that fqdn's were not saved well and I wondered why.

When you clone a host now the fqdn is not taken over as before and the name of the host is empty. It might be a good idea to have this autofilled again.

I have just tested this with full fqdn and it's fixed.

Thanks a lot!!

#14 Updated by Yama Kasi over 5 years ago

Some additional information:

When you set the fqdn on a host, that didn't save the puppet parameters, the paramater is saved but still available for override.

In this situation the fqdn in the "name field" is set back to the hostname only.

When you want to override an extra (add one) paramater and don't set the full fqdn in the name of the host again, the override parameter that already existed is "copied" with an empty scope and name an value of the existed one.

When you add an extra override paramater and also set the fdqn in the name, everything is saved fine.

#15 Updated by Dominic Cleal over 5 years ago

  • Status changed from New to Duplicate

Yama Kasi wrote:

That is very right Dominic, I have seen the same that fqdn's were not saved well and I wondered why.

When you clone a host now the fqdn is not taken over as before and the name of the host is empty. It might be a good idea to have this autofilled again.

That was a deliberate change in #3136 - the old hostname is shown in the title if you need it.

I have just tested this with full fqdn and it's fixed.

Okay, thanks. I'll mark this as a duplicate so we have just one ticket, and we'll continue fixing this in #4234.

Also available in: Atom PDF