Project

General

Profile

Refactor #8516

Remove require 'fog' and only load specific providers

Added by Dominic Cleal over 5 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Performance
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

geemus suggested that we can selectively load providers from fog, cutting down the amount of code we load.

https://github.com/fog/fog/issues/3295#issuecomment-64659051

app/models/concerns/fog_extensions.rb mostly does this already, but does a require 'fog' at the top, as does ssh_provision.rb, and bundler will require the gem by default. These could probably all be removed.

We should ensure though that any plugins using Fog (xen, one, docker(?) etc) all have the appropriate requires in place to ensure their providers are accessible.


Related issues

Related to DigitalOcean - Refactor #10795: Remove require 'fog'Closed2015-06-12
Related to Xen - Bug #10796: Remove require 'fog'Closed2015-06-12
Related to OpenNebula - Bug #10797: Remove require 'fog'Closed2015-06-12
Related to Docker - Refactor #10812: Remove require 'fog'Closed2015-06-14
Blocked by Foreman - Refactor #8641: Update fog version to 1.27.xClosed2014-12-10

Associated revisions

Revision a180c321 (diff)
Added by Tom Caspy about 5 years ago

fixes #8516 - removing the require 'fog' from the project, requiring only what we use

History

#1 Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2017 added
  • Pull request deleted ()

#2 Updated by Dominic Cleal over 5 years ago

  • Assignee set to Tom Caspy

#3 Updated by Dominic Cleal over 5 years ago

#4 Updated by Dominic Cleal about 5 years ago

  • Legacy Backlogs Release (now unused) set to 35

Please ensure foreman_digitalocean, one and xen get updates for this.

#5 Updated by Tom Caspy about 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal almost 5 years ago

#7 Updated by Dominic Cleal almost 5 years ago

  • Related to Bug #10796: Remove require 'fog' added

#8 Updated by Dominic Cleal almost 5 years ago

  • Related to Bug #10797: Remove require 'fog' added

#9 Updated by Dominic Cleal almost 5 years ago

Also available in: Atom PDF