Plugins » DigitalOcean

If I'm reading that correctly, it looks like the DO "UUIDs" being retrieved are actually integers, not UUID strings?

Note that I tried the following based on a suggestion in the #foreman-dev channel

[vagrant@devforeman digitalocean]$ git diff
diff --git a/app/models/concerns/fog_extensions/digitalocean/server.rb b/app/models/concerns/fog_extensions/digitalocean/server.rb
index 5050637..712e2bb 100644
--- a/app/models/concerns/fog_extensions/digitalocean/server.rb
+++ b/app/models/concerns/fog_extensions/digitalocean/server.rb
@@ -3,6 +3,10 @@ module FogExtensions
     module Server
       extend ActiveSupport::Concern

+      def identity
+        super.to_s
+      end
+
       def vm_description
         flavor.try(:name)
       end

However, now it fails immediately on host creation, rather than after the VM is created and ready. It gives the error:

creating VM with the following options: {"name"=>"testvm06.test.example.com", "flavor_id"=>"66", "region_id"=>"4", "image_id"=>"7053293"}
Unhandled DigitalOcean error: Fog::Errors::Error:Resaving an existing object may create a duplicate
 /home/vagrant/.gem/ruby/1.9.1/gems/fog-1.25.0/lib/fog/digitalocean/models/compute/server.rb:118:in `save'
 /home/vagrant/.gem/ruby/1.9.1/gems/fog-core-1.25.0/lib/fog/core/collection.rb:50:in `create'
 /home/vagrant/foreman/app/models/compute_resource.rb:147:in `create_vm'
 /home/vagrant/foreman-digitalocean/app/models/foreman_digitalocean/digitalocean.rb:35:in `create_vm'
 /home/vagrant/foreman/app/models/concerns/orchestration/compute.rb:74:in `setCompute'

Maybe instead of redefining 'identity' you could add a new method which we'll use for retrieving the UUID.

def identity_to_s
  identity.to_s
end

And then change DO's provided_attributes method (https://github.com/theforeman/foreman-digitalocean/blob/master/app/models/foreman_digitalocean/digitalocean.rb#L16) to:

super.merge({ :uuid => :identity_to_s, :ip => :public_ip_address })

That looks like it might work. I have tested it in my development instance, but not on "postgres" yet... However, it looks good form the logs:

  Host::Managed Load (0.2ms)  SELECT "hosts".* FROM "hosts" WHERE "hosts"."uuid" = '3426805' LIMIT 1

Note the single quotes around the uuid number...

Once I figure out a "sane" way to test it against postgres I will submit the PR.

~tommy