Project

General

Profile

Bug #9147

New NIC code causes orchestration issues with plugins due to ordering issues

Added by Greg Sutcliffe over 8 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Orchestration
Target version:
Difficulty:
trivial
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

We currently have checks for host.managed? and managed?in the dhp/dns/tftp orchestration, but they are not the first thing to be checked. as such, it's possible to call methods that don't exist for an STI host class with a new nic (eg discovery will attempt to call ip_available? on import, and fail)

We should move the managed checks to the beginning, since if a host/nic is not managed, it makes no sense to orchestrate anyway.

Associated revisions

Revision 5440d482 (diff)
Added by Greg Sutcliffe over 8 years ago

Fixes #9147 - move managed checks to the start of the DHCP/DNS/TFTP orchestration checks

Revision 88dc8d70 (diff)
Added by Greg Sutcliffe over 8 years ago

Fixes #9147 - move managed checks to the start of the DHCP/DNS/TFTP orchestration checks

(cherry picked from commit 5440d482b0087fe29b3fb4567e0ca73f2d3af221)

History

#1 Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2116 added
  • Pull request deleted ()

#2 Updated by Marek Hulán over 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/2204 added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/2116)

#3 Updated by Greg Sutcliffe over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal over 8 years ago

  • Legacy Backlogs Release (now unused) set to 28

#5 Updated by Bryan Kearney about 8 years ago

  • Assignee changed from Greg Sutcliffe to Marek Hulán

Also available in: Atom PDF