Project

General

Profile

Actions

Bug #9147

closed

New NIC code causes orchestration issues with plugins due to ordering issues

Added by Greg Sutcliffe about 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Orchestration
Target version:
Difficulty:
trivial
Triaged:
Fixed in Releases:
Found in Releases:

Description

We currently have checks for host.managed? and managed?in the dhp/dns/tftp orchestration, but they are not the first thing to be checked. as such, it's possible to call methods that don't exist for an STI host class with a new nic (eg discovery will attempt to call ip_available? on import, and fail)

We should move the managed checks to the beginning, since if a host/nic is not managed, it makes no sense to orchestrate anyway.

Actions #1

Updated by The Foreman Bot about 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2116 added
  • Pull request deleted ()
Actions #2

Updated by Marek Hulán about 9 years ago

  • Pull request https://github.com/theforeman/foreman/pull/2204 added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/2116)
Actions #3

Updated by Greg Sutcliffe about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Dominic Cleal about 9 years ago

  • translation missing: en.field_release set to 28
Actions #5

Updated by Bryan Kearney about 9 years ago

  • Assignee changed from Greg Sutcliffe to Marek Hulán
Actions

Also available in: Atom PDF