Project

General

Custom queries

Profile

Actions
Copy link

Refactor #9553

closed

remove dump_in_quirks_mode

Added by Shlomi Zadok about 10 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomer Brisker
Category:
Rails
Target version:
1.11.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/3178
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

We have created a method that adds quirks_mode => true to JSON.dump
From json ~> 1.8, this option is built into JSON.dump method
We should remove dump_in_quirks_mode from initializers/json.rb

Related issues 2 (0 open — 2 closed)

Related to Foreman - Bug #7764: only generation of JSON objects or arrays allowedClosedShlomi Zadok10/01/2014Actions
Related to Foreman - Refactor #13697: Remove json gemClosedTomer Brisker02/14/2016Actions
Actions
Copy link
 #2

Updated by Shlomi Zadok about 10 years ago

  • Status changed from Closed to Assigned
  • Pull request added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/2202)

Shouldn't be closed until this fixing the issue!
This issue is a reminder to undo the quirks_mode, as it will be supported from json ~> 1.8

Actions
Copy link
 #6

Updated by Anonymous about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF