Project

General

Profile

Bug #10867

Openstack boot from volume always enabled, even if unchecked

Added by Andy Taylor over 5 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Compute resources - OpenStack
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

We've just upgraded our Foreman installation to 1.8.2 and found that our Openstack provisioning stopped working. We've narrowed the issue down to the new Openstack boot from volume code (see http://projects.theforeman.org/issues/4521).

It seems that even if the "Boot from volume" button is unchecked, Foreman still fires the boot_from_volume function in /usr/share/foreman/app/models/compute_resources/foreman/model/openstack.rb. In our infrastructure this broke our provisioning as we don't use Ceph/block device volumes on Openstack.

On line 76 of openstack.rb:

    def create_vm(args = {})
      boot_from_volume(args) if args[:boot_from_volume]
....

When I create a new Openstack VM, boot_from_volume always gets called, even though I can see '"boot_from_volume"=>"false"' in the Foreman logs for the new host.


Related issues

Related to Foreman - Bug #4521: Openstack boot from volumeClosed2014-03-03

Associated revisions

Revision 776cff93 (diff)
Added by Daniel Lobato Garcia over 5 years ago

Fixes #10867 - OpenStack boot_from_volume is true only when checked

Revision ca55ae5c (diff)
Added by Daniel Lobato Garcia over 5 years ago

Fixes #10867 - OpenStack boot_from_volume is true only when checked

(cherry picked from commit 776cff93637b006cb69063fecf142e776acd1378)

Revision 1af68074 (diff)
Added by Daniel Lobato Garcia over 5 years ago

Fixes #10867 - OpenStack boot_from_volume is true only when checked

(cherry picked from commit 776cff93637b006cb69063fecf142e776acd1378)

Revision 5ffe796f (diff)
Added by Dominic Cleal over 5 years ago

refs #10867 - bool cast compatibility with 1.8

History

#1 Updated by Andy Taylor over 5 years ago

Correction, I didn't mean Ceph, I meant Cinder :)

#2 Updated by Marek Hulán over 5 years ago

  • Legacy Backlogs Release (now unused) set to 62

#3 Updated by Marek Hulán over 5 years ago

  • Related to Bug #4521: Openstack boot from volume added

#4 Updated by Daniel Lobato Garcia over 5 years ago

Looks like ` args[:boot_from_volume] ` is going to return true (boolean) for either "true" or "false" strings.

#5 Updated by Dominic Cleal over 5 years ago

Don't forget that we have Foreman::Cast.to_bool now in develop.

#6 Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2498 added
  • Pull request deleted ()

#7 Updated by Dominic Cleal over 5 years ago

  • Assignee set to Daniel Lobato Garcia

#8 Updated by Daniel Lobato Garcia over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF