Project

General

Profile

Feature #12209

Introduce support for dependency injection in dns module

Added by Dmitri Dolguikh over 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
DNS
Target version:
Difficulty:
Triaged:
Bugzilla link:

Related issues

Related to Smart Proxy - Bug #12597: Smart Proxy DNS tests have an extra method definition that is upsetting rubocopClosed2015-11-24
Related to Smart Proxy - Bug #13080: nsupdate module allows to specify mutually exclusive -k and -g options at the same time, which leads to a cryptic "Broken pipe" errorResolved2016-01-08

Associated revisions

Revision 42b95815 (diff)
Added by Dmitri Dolguikh about 4 years ago

Fixes #12209: introduced basic support for di in dns module

DNS record class interface has been cleaned up with validation and type
parsing logic moved into the controller layer, resulting in separate
create and delete methods for A and PTR records.

Revision c1994b8f (diff)
Added by Ewoud Kohl van Wijngaarden almost 4 years ago

Refs #12209: Pass in the actual values to {create,remove}_ptr_record

History

#1 Updated by Dmitri Dolguikh over 4 years ago

  • Category set to DNS
  • Status changed from New to Assigned
  • Assignee set to Dmitri Dolguikh

#2 Updated by The Foreman Bot over 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/329 added
  • Pull request deleted ()

#3 Updated by Ohad Levy over 4 years ago

whats the usage case? could you elaborate?

#4 Updated by Dominic Cleal over 4 years ago

Ohad Levy wrote:

whats the usage case? could you elaborate?

https://github.com/theforeman/smart_proxy_dns_powerdns/pull/8#issuecomment-147664350

#5 Updated by Dmitri Dolguikh over 4 years ago

Also used in puppet_proxy (one of the examples: https://github.com/theforeman/smart-proxy/blob/develop/modules/puppet_proxy/environment.rb) and dhcp (all providers and the main module) modules to handle dependency resolution and lifecycle (instance vs. class vars).

#6 Updated by Lukas Zapletal over 4 years ago

Refactoring ticket without any description, PR has no description. All we have is one comment which mostly explains it, but let's copy&paste things into descriptions please :-)

#7 Updated by Dominic Cleal about 4 years ago

  • Legacy Backlogs Release (now unused) set to 71

#8 Updated by Anonymous about 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#9 Updated by Dominic Cleal about 4 years ago

  • Related to Bug #12597: Smart Proxy DNS tests have an extra method definition that is upsetting rubocop added

#10 Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/384 added

#11 Updated by Dmitri Dolguikh about 3 years ago

  • Related to Bug #13080: nsupdate module allows to specify mutually exclusive -k and -g options at the same time, which leads to a cryptic "Broken pipe" error added

Also available in: Atom PDF