Project

General

Profile

Feature #13417

Wrap Facet registration in plugin API

Added by Eric Helms over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Plugins-Engines
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

The current Facet registration for plugins occurs independently of registering and using the plugin interface. To me, this breaks from the idea of centralizing additions plugins need in the plugin API. Current registration:

  Facets.register(Katello::Host::ContentFacet, :content_facet) do
    api_view :list => 'katello/api/v2/content_facet/base_with_root', :single => 'katello/api/v2/content_facet/show'
  end

Related issues

Related to Foreman - Feature #12630: Facets - Add facet declarationClosed2015-11-30

Associated revisions

Revision 7d90b5cb (diff)
Added by Eric Helms over 3 years ago

Fixes #13417: Provide facet registration through plugin API

Revision 68f9b972 (diff)
Added by Eric Helms over 3 years ago

Fixes #13417: Provide facet registration through plugin API

(cherry picked from commit 7d90b5cb23decf7d9f6f09f8114ea8a9b1f697a0)

History

#1 Updated by Dominic Cleal over 3 years ago

#2 Updated by Dominic Cleal over 3 years ago

  • Category set to Plugins-Engines

#3 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Eric Helms
  • Pull request https://github.com/theforeman/foreman/pull/3134 added

#4 Updated by Eric Helms over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal over 3 years ago

  • Legacy Backlogs Release (now unused) set to 71

#6 Updated by Bryan Kearney over 3 years ago

  • Bugzilla link set to 1326034

#7 Updated by Lukas Zapletal about 3 years ago

Stumbled upon this when I was reading Facet documentation.

http://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Plugin#Facets

Shall we remove the "This is being re-worked into a proper plugin API via #13417, it's highly recommended to use that when available and not use internal APIs." note?

Also available in: Atom PDF