Foreman » Installer

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1402062
Description of problem:
You can run satellite-installer with any value you wish in the DNS/DHCP provider!

Version-Release number of selected component (if applicable):
6.2.4 and probably earlier versions as well.

How reproducible:
Always.

Steps to Reproduce:
1. Run the following command:

satellite-installer -S satellite \
--foreman-proxy-dhcp-provider virsh \
--foreman-proxy-dhcp-server 192.168.122.1 \
--foreman-proxy-dns-server 192.168.122.1 \
--foreman-proxy-dns-provider blabla \
--foreman-proxy-dns true \
--foreman-proxy-dhcp true \
--foreman-proxy-dhcp-interface eth0

Installing Done [100%] [..........................................................]
Success! * Satellite is running at https://rhss62.testenv * To install additional capsule on separate machine continue by running:

capsule-certs-generate --capsule-fqdn "$CAPSULE" --certs-tar "~/$CAPSULE-certs.tar"

The full log is at /var/log/foreman-installer/satellite.log

Actual results:
satellite-installer starts and complete the installation without any warning/error message!

Expected results:
It should accept only the foreman-proxy providers.

Additional info:

cat ./dns.yml
---

1. DNS management
   :enabled: https
2. valid providers:
3. dns_dnscmd (Microsoft Windows native implementation)
4. dns_nsupdate
5. dns_nsupdate_gss (for GSS-TSIG support)
6. dns_virsh (simple implementation for libvirt)
   :use_provider: dns_blabla
7. use this setting if you want to override default TTL setting (86400)
   :dns_ttl: 86400