Bug #19067
closed
Added by J. A. over 7 years ago.
Updated almost 6 years ago.
Description
When viewing diffs in Foreman, such as filebucket diffs in puppet reports, or history diffs in provisioning templates et al, added lines show up in black, and removed lines show up in green. Also, these two colors are reversed for the + and - symbols prefixing the lines (+ in green, - in black).
I suggest using green for additions (+), red for removals (-), and using the same color for the prefix symbol as the rest of the line.
- Category set to Web Interface
- Assignee set to matan werbner
- Assignee deleted (
matan werbner)
unassign, still an issue.
- Pull request https://github.com/theforeman/foreman/pull/6138 added
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/6180 added
- Target version set to 1.21.0
- Pull request deleted (
https://github.com/theforeman/foreman/pull/6180)
- Fixed in Releases 1.21.0 added
just for clarification, this adds Diff for the audit page, follow up pull requests to other places where diff is shown in the app will follow.
- Status changed from Ready For Testing to Closed
- Pull request https://github.com/theforeman/foreman/pull/6180 added
- Assignee set to Ohad Levy
- Pull request https://github.com/theforeman/foreman/pull/6256 added
- Pull request deleted (
https://github.com/theforeman/foreman/pull/6180)
Also available in: Atom
PDF