Bug #20317
Rails 5 compatibility
Status:
Closed
Priority:
Normal
Assignee:
Category:
Upgrades
Target version:
Difficulty:
Triaged:
Pull request:
https://github.com/Katello/katello/pull/7128, https://github.com/Katello/katello/pull/7127, https://github.com/Katello/katello/pull/6983, https://github.com/Katello/katello/pull/7134, https://github.com/Katello/katello/pull/7132, https://github.com/Katello/katello/pull/7130, https://github.com/Katello/katello/pull/6957, https://github.com/Katello/katello/pull/6972, https://github.com/Katello/katello/pull/6875, https://github.com/Katello/katello/pull/6883
Description
There are a few things that are not currently working in Katello when using Rails 5:
- Cannot boot without modifying lib/katello/katello.rb to use the right middleware
- Tests do not seem to run
Related issues
Associated revisions
Refs #20317 - rails 5 test fixes
Refs #20317 - small updates for rails 5
Refs #20317 - stop using use_transactional_fixtures
Refs #20317 - stop using HttpPositionalArguments
Refs #20317 - use .id with find in test
Refs #20317 - Reorder AR associations in order of use
Refs #20317 - Replace 'false' AR callback result with throw
Refs #20317 - Reorder AR associations in order of use
Refs #20317 - use .id with find in tests
Refs #20317 - Use "distinct" in AR finders
Refs #20317 - Replace render :text with :plain
Refs #20317 - Rails 5.1 fixes
History
#1
Updated by The Foreman Bot almost 5 years ago
Updated by - Status changed from New to Ready For Testing
- Assignee set to Daniel Lobato Garcia
- Pull request https://github.com/Katello/katello/pull/6875 added
#2
Updated by Justin Sherrill almost 5 years ago
Updated by - Legacy Backlogs Release (now unused) set to 284
#3
Updated by The Foreman Bot almost 5 years ago
- Pull request https://github.com/Katello/katello/pull/6883 added
#4
Updated by Tomer Brisker almost 5 years ago
Updated by - Blocks Tracker #15715: Rails 5.0 upgrade tasks added
#5
Updated by The Foreman Bot almost 5 years ago
- Pull request https://github.com/Katello/katello/pull/6957 added
#6
Updated by The Foreman Bot almost 5 years ago
- Pull request https://github.com/Katello/katello/pull/6972 added
#7
Updated by The Foreman Bot over 4 years ago
- Pull request https://github.com/Katello/katello/pull/6983 added
#8
Updated by Daniel Lobato Garcia over 4 years ago
Updated by Closed by means of #21019
#9
Updated by Anonymous over 4 years ago
- Related to Tracker #20948: Rails 5.1 upgrade tasks added
#10
Updated by Anonymous over 4 years ago
- Blocks deleted (Tracker #15715: Rails 5.0 upgrade tasks)
#11
Updated by Anonymous over 4 years ago
- Related to Tracker #15715: Rails 5.0 upgrade tasks added
#12
Updated by The Foreman Bot over 4 years ago
- Pull request https://github.com/Katello/katello/pull/7127 added
#13
Updated by The Foreman Bot over 4 years ago
- Pull request https://github.com/Katello/katello/pull/7128 added
#14
Updated by Tomer Brisker over 4 years ago
- Related to Bug #22073: Test failure on Rails 5.1 added
#15
Updated by The Foreman Bot over 4 years ago
- Pull request https://github.com/Katello/katello/pull/7130 added
#16
Updated by The Foreman Bot over 4 years ago
- Pull request https://github.com/Katello/katello/pull/7132 added
#17
Updated by The Foreman Bot over 4 years ago
- Pull request https://github.com/Katello/katello/pull/7134 added
#18
Updated by Anonymous over 4 years ago
- Status changed from Ready For Testing to Closed
Refs #20317 - correct initializer of models
This corrects these errors as part of rails 5 work:
Katello::ProductCreateTest#test_unique_label_per_organization:
ArgumentError: wrong number of arguments (2 for 0..1)
/home/vagrant/katello/app/models/katello/glue/candlepin/product.rb:76:in initialize
/home/vagrant/katello/app/models/katello/product.rb:89:in initialize
/home/vagrant/katello/test/models/product_test.rb:8:in setup