Project

General

Profile

Bug #20317

Rails 5 compatibility

Added by Daniel Lobato Garcia about 2 years ago. Updated about 1 year ago.


Description

There are a few things that are not currently working in Katello when using Rails 5:

  • Cannot boot without modifying lib/katello/katello.rb to use the right middleware
  • Tests do not seem to run

Related issues

Related to Foreman - Tracker #20948: Rails 5.1 upgrade tasksClosed2017-09-16

Related to Foreman - Tracker #15715: Rails 5.0 upgrade tasksResolved2016-07-18

Related to Katello - Bug #22073: Test failure on Rails 5.1Closed2017-12-26

Associated revisions

Revision 2a112087 (diff)
Added by Justin Sherrill about 2 years ago

Refs #20317 - correct initializer of models

This corrects these errors as part of rails 5 work:

Katello::ProductCreateTest#test_unique_label_per_organization:
ArgumentError: wrong number of arguments (2 for 0..1)
/home/vagrant/katello/app/models/katello/glue/candlepin/product.rb:76:in initialize
/home/vagrant/katello/app/models/katello/product.rb:89:in initialize
/home/vagrant/katello/test/models/product_test.rb:8:in setup

Revision 79d32bbf (diff)
Added by Justin Sherrill almost 2 years ago

Refs #20317 - rails 5 test fixes

Revision 9af80baf (diff)
Added by Justin Sherrill almost 2 years ago

Refs #20317 - small updates for rails 5

Revision d0798ce2 (diff)
Added by Michael Moll over 1 year ago

Refs #20317 - stop using use_transactional_fixtures

Revision 05a7b292 (diff)
Added by Michael Moll over 1 year ago

Refs #20317 - stop using HttpPositionalArguments

Revision 4bfc3867 (diff)
Added by Michael Moll over 1 year ago

Refs #20317 - use .id with find in test

Revision 07627d2f (diff)
Added by Michael Moll over 1 year ago

Refs #20317 - Reorder AR associations in order of use

Revision 8288f0b2 (diff)
Added by Michael Moll over 1 year ago

Refs #20317 - Replace 'false' AR callback result with throw

Revision 2334beda (diff)
Added by Michael Moll over 1 year ago

Refs #20317 - Reorder AR associations in order of use

Revision 0bac217b (diff)
Added by Michael Moll over 1 year ago

Refs #20317 - use .id with find in tests

Revision fda67090 (diff)
Added by Michael Moll over 1 year ago

Refs #20317 - Use "distinct" in AR finders

Revision 841d1ada (diff)
Added by Michael Moll over 1 year ago

Refs #20317 - Replace render :text with :plain

Revision c348873e (diff)
Added by Jonathon Turel over 1 year ago

Refs #20317 - Rails 5.1 fixes

History

#1 Updated by The Foreman Bot about 2 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/Katello/katello/pull/6875 added

#2 Updated by Justin Sherrill about 2 years ago

  • Legacy Backlogs Release (now unused) set to 284

#3 Updated by The Foreman Bot about 2 years ago

  • Pull request https://github.com/Katello/katello/pull/6883 added

#4 Updated by Tomer Brisker almost 2 years ago

#5 Updated by The Foreman Bot almost 2 years ago

  • Pull request https://github.com/Katello/katello/pull/6957 added

#6 Updated by The Foreman Bot almost 2 years ago

  • Pull request https://github.com/Katello/katello/pull/6972 added

#7 Updated by The Foreman Bot almost 2 years ago

  • Pull request https://github.com/Katello/katello/pull/6983 added

#8 Updated by Daniel Lobato Garcia almost 2 years ago

Closed by means of #21019

#9 Updated by Michael Moll over 1 year ago

#10 Updated by Michael Moll over 1 year ago

#11 Updated by Michael Moll over 1 year ago

#12 Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/Katello/katello/pull/7127 added

#13 Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/Katello/katello/pull/7128 added

#14 Updated by Tomer Brisker over 1 year ago

  • Related to Bug #22073: Test failure on Rails 5.1 added

#15 Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/Katello/katello/pull/7130 added

#16 Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/Katello/katello/pull/7132 added

#17 Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/Katello/katello/pull/7134 added

#18 Updated by Michael Moll over 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF