Project

General

Profile

Refactor #20846

refactor usage of ES6 Map to using _set

Added by Sebastian Gräßl almost 2 years ago. Updated about 1 year ago.

Status:
Rejected
Priority:
Normal
Assignee:
Sebastian Gräßl
Category:
Tests
Target version:
1.17.0
Difficulty:
easy
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4809
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

#195541 introduced the use of `Map`, which needs to be enabled (still) to be used in older browsers that do not support it yet, like the browser used for integration tests.

See https://babeljs.io/learn-es2015/#ecmascript-2015-features-map-set-weak-map-weak-set

[1]https://github.com/theforeman/foreman/pull/4792

Related issues

Related to Foreman - Feature #19554: Provide warning for unsupported PXE loader combinationsClosed2017-05-16

History

#1 Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4809 added

#2 Updated by Daniel Lobato Garcia almost 2 years ago

  • Status changed from Ready For Testing to Closed

Closing as the PR was replaced by https://github.com/theforeman/foreman/pull/4811

#3 Updated by Ohad Levy almost 2 years ago

  • Tracker changed from Bug to Refactor
  • Subject changed from Enable ES6 Map support to refactor usage of ES6 Map to using _set

#4 Updated by Ohad Levy almost 2 years ago

  • Related to Feature #19554: Provide warning for unsupported PXE loader combinations added

#5 Updated by Ohad Levy almost 2 years ago

  • Legacy Backlogs Release (now unused) set to 240

#6 Updated by Daniel Lobato Garcia almost 2 years ago

  • Legacy Backlogs Release (now unused) changed from 240 to 296

#7 Updated by Ohad Levy almost 2 years ago

  • Status changed from Closed to Rejected

instead of adding support for ES6 map, we ended up rewriting the patch to not use Map.

Also available in: Atom PDF