Project

General

Profile

Feature #19554

Provide warning for unsupported PXE loader combinations

Added by Lukas Zapletal almost 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Host creation
Target version:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Users very often try to provision RHEL 6 with Grub2 in UEFI which leads to boot loading errors (bacically Grub2 prompt or kernel panic).

We need a warning next to PXE Loader flag in the UI if there is known combination of OS and loader that does not work. These currently are:

  • RHEL 6.x and Grub2
  • RHEL 7.x and Grub1
  • Ubuntu 10.x or older and Grub2
  • Ubuntu 11.x or newer and Grub1
  • Debian 2-6 and Grub2
  • Debian 7+ and Grub1

This can be as simple as regular expression and a warning message showing up next to the field in the UI. No actions must be taken. A global setting should be present which will turn this feature of in case user do not want to see these warnings.


Related issues

Related to Foreman - Refactor #20846: refactor usage of ES6 Map to using _setRejected2017-09-05

Associated revisions

Revision 805420d1 (diff)
Added by Tomáš Strachota over 5 years ago

Fixes #19554 - Warning for unsupported PXE loader combinations

Revision f9ba69d7 (diff)
Added by Tomáš Strachota over 5 years ago

Fixes #19554 - Warning for unsupported PXE loader combinations

Revision 9f701b61 (diff)
Added by Tomáš Strachota over 5 years ago

Fixes #19554 - Warning for unsupported PXE loader combinations

Revision a940ec7c (diff)
Added by Sebastian Gräßl over 5 years ago

Refs #19554 - Rewrite to use an Object and not Map

Map is not yet fully supported in all browsers and
would require additional dependencies to be added.

Using a Object with lodash functions achieves the
same and does not require any additional
dependencies.

Revision 62fb64c6 (diff)
Added by Tomáš Strachota over 5 years ago

Fixes #19554 - Warning for unsupported PXE loader combinations

(cherry picked from commit 805420d18ae67be2fa76cc433ef58b685a640afa)

Revision 187ac8c8 (diff)
Added by Sebastian Gräßl over 5 years ago

Refs #19554 - Rewrite to use an Object and not Map

Map is not yet fully supported in all browsers and
would require additional dependencies to be added.

Using a Object with lodash functions achieves the
same and does not require any additional
dependencies.

(cherry picked from commit a940ec7c1cc821212617827633dea46ffd2749c4)

History

#1 Updated by Lukas Zapletal almost 6 years ago

Good idea would be our status API to do this kind of warnings.

#2 Updated by Marek Hulán over 5 years ago

  • Target version set to 1.17.0-RC2

#3 Updated by Tomáš Strachota over 5 years ago

  • Status changed from New to Assigned
  • Assignee set to Tomáš Strachota

#4 Updated by Lukas Zapletal over 5 years ago

Just to clear things little bit, these are known and supported cobinations, we should only issue warning if ANY of these rules are not true:

  • RHEL 6.x and Grub1
  • RHEL 7.x and Grub2
  • Ubuntu 10.x or older and Grub1
  • Ubuntu 11.x or newer and Grub2
  • Debian 2-6 and Grub1
  • Debian 7+ and Grub2

It's actually the opposite of unsupported combinations in the original description. I think we should have a list of supported pairs rather than unsupported, that's all.

#5 Updated by Marek Hulán over 5 years ago

  • Target version changed from 1.17.0-RC2 to 1.18.0-RC2

#6 Updated by The Foreman Bot over 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4792 added

#7 Updated by Marek Hulán over 5 years ago

  • Target version changed from 1.18.0-RC2 to 214

#8 Updated by Anonymous over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#9 Updated by Daniel Lobato Garcia over 5 years ago

  • Legacy Backlogs Release (now unused) set to 287

Given the entirety of the check is contained in a class "PXECompatibilityCheck" added in this PR, I'm marking as 1.15.4 as it's very useful.

#10 Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4810 added

#11 Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4811 added

#12 Updated by Daniel Lobato Garcia over 5 years ago

  • Legacy Backlogs Release (now unused) changed from 287 to 296

#13 Updated by Ohad Levy over 5 years ago

  • Related to Refactor #20846: refactor usage of ES6 Map to using _set added

#14 Updated by Ohad Levy over 5 years ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/4810)

#15 Updated by roman plevka over 5 years ago

  • Bugzilla link set to 1489377

Also available in: Atom PDF