Project

General

Custom queries

Profile

Actions
Copy link

Refactor #20846

closed

refactor usage of ES6 Map to using _set

Added by Sebastian Gräßl over 7 years ago. Updated almost 7 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Sebastian Gräßl
Category:
Tests
Target version:
1.17.0
Difficulty:
easy
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4809
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

#195541 introduced the use of `Map`, which needs to be enabled (still) to be used in older browsers that do not support it yet, like the browser used for integration tests.

See https://babeljs.io/learn-es2015/#ecmascript-2015-features-map-set-weak-map-weak-set

[1]https://github.com/theforeman/foreman/pull/4792

Related issues 1 (0 open — 1 closed)

Related to Foreman - Feature #19554: Provide warning for unsupported PXE loader combinationsClosedTomáš Strachota05/16/2017Actions
Actions
Copy link
 #2

Updated by Daniel Lobato Garcia over 7 years ago

  • Status changed from Ready For Testing to Closed

Closing as the PR was replaced by https://github.com/theforeman/foreman/pull/4811

Actions
Copy link
 #7

Updated by Ohad Levy over 7 years ago

  • Status changed from Closed to Rejected

instead of adding support for ES6 map, we ended up rewriting the patch to not use Map.

Actions
Copy link

Also available in: Atom PDF