Project

General

Profile

Actions
Copy link

Bug #20933

closed

Subtotal is being incorrectly set in tasks controller index

Added by Walden Raines about 7 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

The subtotal is being set to the count of the results which is incorrect. This results in behavior where pagination is unusable because the subtotal ends up being the total number of results if less than the per page value or the per page value otherwise. In the latter case it is impossible to go to page two in the UI because we use the subtotal to calculate pagination.

Other controllers in katello don't exhibit this behavior. I believe the subtotal should be the number of items that match a particular search.

https://github.com/theforeman/foreman-tasks/blob/master/app/controllers/foreman_tasks/api/tasks_controller.rb#L138

Related issues 1 (0 open — 1 closed)

Blocks Katello - Bug #20393: Foreman tasks table should be using index method instead of bulk_searchClosedDan Seethaler06/25/2017Actions
Actions
Copy link
 #2

Updated by Walden Raines about 7 years ago

  • Blocks Bug #20393: Foreman tasks table should be using index method instead of bulk_search added
Actions
Copy link
 #3

Updated by Walden Raines about 7 years ago

  • Assignee set to Ivan Necas

Assigning to Ivan, please feel free to delegate as appropriate.

Actions
Copy link
 #4

Updated by Ivan Necas about 7 years ago

  • Assignee deleted (Ivan Necas)

Please don't assign the folks to the issues on creation: it causes a false assumption they're working on it + discourages others from looking into it. Thanks

Actions
Copy link
 #5

Updated by Adam Ruzicka over 3 years ago

  • Status changed from New to Closed

This should be fixed since we started using the index layout from foreman core.

Actions
Copy link

Also available in: Atom PDF