Feature #2675
closedMetrics in summary email should be sorted
Description
The metrics in the daily summary mail are not sorted and change order every day, which is confusing.
My ruby knowledge is zero - but the attached patch seems to fix it.
Please review and fix - I am very unsure, if the second sort will work correctly...
Regards,
Dirk.
Files
Updated by Dominic Cleal almost 12 years ago
Thanks for the patch Dirk. If you're comfortable with git, please submit it as a pull request to our GitHub repo, but if not hopefully somebody can do this on your behalf and double check it.
Updated by Dirk Melchers almost 12 years ago
Dominic Cleal wrote:
Thanks for the patch Dirk. If you're comfortable with git, please submit it as a pull request to our GitHub repo, but if not hopefully somebody can do this on your behalf and double check it.
I would prefer if someone else could do this - because someone who knows ruby and .erb-files has to check it again!
Updated by Amir Fefer about 9 years ago
- Status changed from Ready For Testing to Resolved
Metrics in summary email already sorted, as you can see here:
https://github.com/theforeman/foreman/blob/develop/app/mailers/host_mailer.rb#L11