Project

General

Profile

Actions
Copy link

Refactor #27172

closed

Do not use !important in layout stylesheets

Added by Ondřej Pražák over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Pražák
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
1724608
Pull request:
https://github.com/theforeman/foreman/pull/6863
Fixed in Releases:
1.23.0
Found in Releases:
Red Hat JIRA:

Description

To apply different theme to foreman, we need to override existing styles, therefore we should avoid using !important.

Related issues 1 (1 open — 0 closed)

Related to Foreman - Bug #27195: Plugin stylesheet bundles contain styles from coreReady For TestingAvi SharvitActions
Actions
Copy link
 #1

Updated by Ondřej Pražák over 5 years ago

  • Bugzilla link set to 1724608
Actions
Copy link
 #2

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6863 added
Actions
Copy link
 #3

Updated by Marek Hulán over 5 years ago

  • Fixed in Releases 1.23.0 added
Actions
Copy link
 #4

Updated by Ondřej Pražák over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #5

Updated by Ondřej Pražák over 5 years ago

  • Related to Bug #27195: Plugin stylesheet bundles contain styles from core added
Actions
Copy link
 #6

Updated by Amit Upadhye over 5 years ago

  • Category set to JavaScript stack
Actions
Copy link

Also available in: Atom PDF