Bug #4234
closedCannot edit host's puppet parameters
Description
I try to override puppet class parameters, when i submit modifications they are not recorded. It works if i use Matcher Value in Puppet Class view. I don't see anything in foreman logs even in debug mode.
Updated by Alexandre Barth over 10 years ago
New information : if i create a new host named foo, in puppet classes smart class parameter, it adds the matcher fqdn=foo instead of fqdn=foo.domain. If i add the domain to the matcher when i edit the host values are then overrided.
Updated by Alexandre Barth over 10 years ago
So i solved the problem providing fqdn as name instead of shortname when creating a new host. Isn't this useless as we must provide domain in network tab ?
And when i edit the host after creation, display name is the shortname ... maybe caus i use the use_shortname_for_vms setting
Updated by Dominic Cleal over 10 years ago
- Category set to Host creation
- Translation missing: en.field_release deleted (
2)
Probably unrelated to the VM setting, pretty sure that only affects the compute resource.
Updated by Alexandre Barth over 10 years ago
i'm using a vmware compute resource.
Updated by Dominic Cleal over 10 years ago
- Related to Bug #4227: Override Parameter not saved in Host added
Updated by Dominic Cleal over 10 years ago
I suspect this is due to this change:
https://github.com/theforeman/foreman/commit/4bae5cedb8ab562b6c397234c5cb1cfd604fde74#diff-2d53894341fd1cf84a823e3bd0855495L740
Stephen, do you remember why that was?
Updated by Dominic Cleal over 10 years ago
Confirmed that restoring the line fixes #4227. I suspect though adding it here might lead to multiple errors being added (line 777), and we need to check the other code above it is OK with being run multiple times.
Updated by Stephen Benjamin over 10 years ago
What do you think about providing an fqdn getter to ensure we always return an fqdn?
Like this:
https://github.com/stbenjam/foreman/compare/4234-override-host-parameters
Figured I'd ask before opening the PR to see if you had a better idea in mind.
Updated by Dominic Cleal over 10 years ago
- Status changed from New to Ready For Testing
- Assignee set to Stephen Benjamin
- Target version set to 1.9.2
- Translation missing: en.field_release set to 5
Updated by Anonymous over 10 years ago
- Target version changed from 1.9.2 to 1.9.1
Updated by Anonymous over 10 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 130f301a508ae31549145e5fa9b176f42dc20995.