Project

General

Profile

Bug #5785

Override class parameter by subnet no longer works since 1.5

Added by Ewoud Kohl van Wijngaarden about 6 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Parameters
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

I have a puppet class parameter (master for munin::client) with the following order:

fqdn
subnet
hostgroup
os
domain

Then a match

subnet=172.17.0.0/16
with some value.

Before I upgraded to 1.5 the override worked, but since I upgraded to 1.5 it no longer does. I can see that since machines with subnet=172.17.0.0/16 no longer have munin graphs since the upgrade. One node that's in noop still has the correct master, but wants to change it to the default as well.


Related issues

Related to Foreman - Bug #16025: Import subnets from proxy returns 500Closed2016-08-09

Associated revisions

Revision 6c09e04f (diff)
Added by Ori Rabin about 4 years ago

Fixes #5785 - override class parameter by subnet name

History

#2 Updated by Tomer Brisker about 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Ori Rabin

Currently subnet matchers only work on the subnet label (for example, "subnet1 (192.168.1.0/24)").
This should be updated to match either the name or the network, or the documentation should be updated to indicate this behaviour.

#3 Updated by The Foreman Bot about 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3601 added

#4 Updated by Dominic Cleal about 4 years ago

  • Category set to Parameters
  • Legacy Backlogs Release (now unused) set to 160

#5 Updated by Ori Rabin about 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal about 4 years ago

  • Related to Bug #16025: Import subnets from proxy returns 500 added

Also available in: Atom PDF