Project

General

Profile

Bug #11596

Error generating IP: Not Found shoud not be in the IP field

Added by Lukas Zapletal almost 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
High
Assignee:
Category:
DHCP
Target version:
Difficulty:
easy
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

The "Error generating IP: Not Found" error is being inserted in the field itself on error (e.g. proxy is not reachable). This is not only nice from the UX standpoint, but when you try to create new host with proxy unavaiable and you don't even open the interface form and submit, the IP is kept set to this string, which causes validation error. We should totally leave IP field empty on errors showing this message as a proper validation error.

Assigning to Shimon who introduced this behavior.


Related issues

Related to Foreman - Bug #10976: Unused IP button does not work anymoreClosed2015-07-02
Related to Foreman - Bug #12859: "Suggest new" link for IP address on interface model window doesn't workClosed2015-12-17

Associated revisions

Revision 7027757a (diff)
Added by Shimon Shtein almost 4 years ago

Fixes #11596 - Changed the javascript to put the error near te ip field, not inside it.

History

#1 Updated by Lukas Zapletal almost 4 years ago

  • Related to Bug #10976: Unused IP button does not work anymore added

#2 Updated by Lukas Zapletal almost 4 years ago

  • Priority changed from Normal to High

For the record, this is not just a cosmetic thing. It breaks DHCP IP address assignement if you have multiple subnets and you want to suggest an IP address from other subnet that is pre-selected (the first one usually).

#3 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2650 added
  • Pull request deleted ()

#4 Updated by Shimon Shtein almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 63

#6 Updated by Marek Hulán over 3 years ago

  • Related to Bug #12859: "Suggest new" link for IP address on interface model window doesn't work added

Also available in: Atom PDF