Project

General

Profile

Feature #15779

Make report, puppet classes and environments importing asynchronous using foreman-tasks

Added by Marek Hulán about 5 years ago. Updated about 3 years ago.


Description

There are already 90% done on foreman-tasks side so we can just move it to core. For importing puppet objects it might make sense to keep synchronous way still available.


Related issues

Related to Foreman - Feature #7514: add foreman tasks into coreNew
Related to Installer - Feature #17467: Configure tasks by defaultDuplicate2016-11-23
Related to Foreman - Bug #17482: Incorrect concatentation of environment import strings to form sentencesRejected2016-11-25
Related to Foreman - Refactor #17483: Async HTTP API calls should return code 202 Accepted instead of 201 CreatedClosed2016-11-25
Related to Foreman - Bug #17495: Align foreman configuration report expiry with Task expiryClosed2016-11-27
Related to Foreman - Bug #17575: "Failed importing of report" error printed to stderr when running testsNew2016-12-05
Related to Foreman - Bug #17871: Circular dependency detected while autoloading constant ConfigReportStatusCalculatorNew2016-12-29
Blocked by foreman-tasks - Bug #15778: Can't use process_success Foreman method in API controllers on DynflowTaskClosed2016-07-22
Blocks foreman-tasks - Refactor #15770: Move reports import and puppet class/environments importing to Foreman coreReady For Testing2016-07-21
Blocks Hammer CLI - Feature #15780: Support async importing from puppet masterClosed2016-07-22
Blocked by foreman-tasks - Feature #17283: In thread executor for testing inside transactionsClosed2016-11-09
Blocked by Foreman - Bug #17361: `rake db:drop db:create db:migrate` doesn't migrate pluginsClosed2016-11-16

Associated revisions

Revision eb371ca3 (diff)
Added by Marek Hulán almost 5 years ago

Fixes #15779 - make background processing available

Revision 1538b8d2 (diff)
Added by Ivan Necas almost 5 years ago

Refs #15779 - move the foreman-tasks to own bundle group

This makes it easier to achieve a minimal setup, that might be needed for
things like plugins building etc.

Revision 35c14172 (diff)
Added by Ivan Necas over 4 years ago

Refs #15779 - make background processing unavailable for now (#4217)

The original PR got vetted in the packaging phase and including
foreman-task as dependency of Foreman was refused. We need to rethink
our approach for getting the foreman-tasks functionality available
inside the core and take less obtrusive approach by making the
transition in several steps, until the foreman core will get on
future-parity with foreman-tasks which would effectively mean tasks in
core.

To clean the tasks that were created while using the original changes,
you can run:

rake foreman_tasks:cleanup\
TASK_SEARCH="label = Actions::Foreman::Report::Import
OR label = Actions::Foreman::PuppetClass::Import"\
VERBOSE=true

This reverts commits

eb371ca33dcdd7a4f71d3cda0cfcad701cd3ae7e,
69c34cd691aea4c7f21613f3859ae92a5f403529,
3a1cd1dbeb74c60a482d7c47fc290c185d7c707a,
0cf8ea6780c24954ccbe2cc33ca02e1f6010ffed,
1538b8d2addb12f04da36a2c34224cd821e77acc,
33709ef2813d0128f64905c6597616f44abad28e.

History

#1 Updated by Marek Hulán about 5 years ago

  • Blocked by Bug #15778: Can't use process_success Foreman method in API controllers on DynflowTask added

#2 Updated by Marek Hulán about 5 years ago

  • Blocks Refactor #15770: Move reports import and puppet class/environments importing to Foreman core added

#3 Updated by Marek Hulán about 5 years ago

  • Blocks Feature #15780: Support async importing from puppet master added

#4 Updated by The Foreman Bot about 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3670 added

#5 Updated by Marek Hulán about 5 years ago

#6 Updated by Ivan Necas almost 5 years ago

  • Blocked by Feature #17283: In thread executor for testing inside transactions added

#7 Updated by Ivan Necas almost 5 years ago

  • Blocked by Bug #17361: `rake db:drop db:create db:migrate` doesn't migrate plugins added

#8 Updated by Ivan Necas almost 5 years ago

#9 Updated by Marek Hulán almost 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#10 Updated by Dominic Cleal almost 5 years ago

  • Related to Bug #17482: Incorrect concatentation of environment import strings to form sentences added

#11 Updated by Ewoud Kohl van Wijngaarden almost 5 years ago

  • Related to Refactor #17483: Async HTTP API calls should return code 202 Accepted instead of 201 Created added

#12 Updated by Dominic Cleal almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 189

#13 Updated by Marek Hulán almost 5 years ago

  • Target version set to 1.4.4

#14 Updated by Ohad Levy almost 5 years ago

  • Related to Bug #17495: Align foreman configuration report expiry with Task expiry added

#15 Updated by The Foreman Bot almost 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4075 added

#16 Updated by Dominic Cleal almost 5 years ago

  • Legacy Backlogs Release (now unused) changed from 189 to 209

Moving due to continuing build/test failures.

#17 Updated by Dominic Cleal almost 5 years ago

  • Related to Bug #17575: "Failed importing of report" error printed to stderr when running tests added

#18 Updated by Marek Hulán almost 5 years ago

Could you please be more specific? What is failing? The rpm packaging PR was awaiting the core PR to be merged, which is in now and the packaging PR is green atm. Thank you.

#19 Updated by Dominic Cleal almost 5 years ago

Debian package tests of foreman have been failing since 25/11 (e.g. http://ci.theforeman.org/job/systest_foreman/11422/) as the dependency isn't correctly packaged. RPM builds of foreman have been failing since the same as bundler.d/foreman_tasks.rb is unpackaged.

The packaging PRs were and are still outstanding - if they were finished, worked and tested then it might have been feasible, but they were not.

#20 Updated by The Foreman Bot almost 5 years ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/1436 added

#21 Updated by The Foreman Bot almost 5 years ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/1437 added

#22 Updated by Ohad Levy over 4 years ago

  • Related to Bug #17871: Circular dependency detected while autoloading constant ConfigReportStatusCalculator added

#23 Updated by The Foreman Bot over 4 years ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/1493 added

#24 Updated by The Foreman Bot over 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4217 added

Also available in: Atom PDF