Project

General

Profile

Refactor #26198

ensure host list does not trigger a full page reload

Added by Ohad Levy about 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ohad Levy
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/6529, https://github.com/theforeman/foreman/pull/6703, https://github.com/theforeman/foreman/pull/6646, https://github.com/theforeman/foreman/pull/6638
Fixed in Releases:
1.22.0
Found in Releases:
Red Hat JIRA:

Description

remove custom JS such as host_checkboxes from asset pipeline to webpack to allow turbolinks not to do a full page reload

Related issues

Related to Foreman - Task #23451: move all javascript/css assets to webpackNew2018-04-30
Related to Foreman - Bug #27831: Disabled buttons are still workingClosed

Associated revisions

Revision ac1fe0de (diff)
Added by Ohad Levy about 4 years ago

fixes #26198 - ensure host list does not require full page reload

Revision 602ba31f (diff)
Added by Tomer Brisker almost 4 years ago

Refs #26198 - return result from deprecated js functions

Also, specify which version to remove them

Revision 1f29f0ac (diff)
Added by Kavita Gaikwad almost 4 years ago

Refs #26198 - fix resetSelection() calling as moved to react file

Revision 2d2f8479 (diff)
Added by Tomer Brisker almost 4 years ago

Refs #26198 - Replace foreman_url with tfm.tools.foremanURL

ac1fe0d moved the foreman_url js function to webpack and deprecated the
old version but there were still a couple of places calling it causing
warnings in the console. This replaces those use cases with the newer
function.

History

#1 Updated by The Foreman Bot about 4 years ago

  • Assignee set to Ohad Levy
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6529 added

#2 Updated by Timo Goebel about 4 years ago

  • Fixed in Releases 1.22.0 added

#3 Updated by Ohad Levy about 4 years ago

  • Status changed from Ready For Testing to Closed

#4 Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6638 added

#5 Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6646 added

#6 Updated by Ohad Levy almost 4 years ago

  • Related to Task #23451: move all javascript/css assets to webpack added

#7 Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6703 added

#8 Updated by Tomer Brisker over 3 years ago

  • Related to Bug #27831: Disabled buttons are still working added

#9 Updated by Kavita Gaikwad over 3 years ago

  • Related to Bug #28236: Uncaught ReferenceError: foreman_url is not defined on selecting life cycle env while creating/editing hostgroup added

#10 Updated by Kavita Gaikwad over 3 years ago

  • Related to deleted (Bug #28236: Uncaught ReferenceError: foreman_url is not defined on selecting life cycle env while creating/editing hostgroup)

Also available in: Atom PDF