Bug #14692: Unable to change own username through web UI - Foreman

Custom queries

3.12.2 release DONE
3.12.2 release TODO
3.13.1 release DONE
3.13.1 release TODO
3.14.0 release DONE
3.14.0 release TODO
All bugs by votes
All issues closed in the last 3 weeks
Easy and Trivial Issues
Easy Issues (only)
Foreman - new open issues in last 10 days
Good first issues - Foreman core
high prio open bugs
Host registration [open]
Mine
My issues closed in the last 3 weeks
old bugs
Open with target version set (aka blockers)
registration
taken-none
Team Atlas untriaged bugs
templates
Trivial Issues
Untriaged and opened in the past two weeks

Actions

Copy link

Bug #14692

closed

Unable to change own username through web UI

Added by Brad Buckingham almost 9 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Low

Assignee:

Rahul Bajaj

Category:

Web Interface

Target version:

Difficulty:

Triaged:

Bugzilla link:

1327661

Pull request:

https://github.com/theforeman/foreman/pull/4579

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1327661
Description of problem:
When user tries to update his username via My Account > User dialog, there is no error shown on trying to put a blank username in. Instead there is a success notification displayed but the username stays unchanged (so it's more of a cosmetic issue).

Version-Release number of selected component (if applicable):
6.2.0 snap 8.1

How reproducible:
always

Steps to Reproduce:
1. navigate to my profile
2. try to change your username to "" or " "

Actual results:
Successfully updated <username> //changes have no effect

Expected results:
"can't be blank" Error

Additional info:

Files

Screenshot from 2016-04-19 07-50-22.png

View Screenshot from 2016-04-19 07-50-22.png

8.06 KB

Dominic Cleal, 04/19/2016 02:52 AM

Related issues 1 (0 open — 1 closed)

Has duplicate Foreman - Bug #19946: Unable to change the User-name by the user

Duplicate

Rahul Bajaj

06/07/2017

Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by Dominic Cleal almost 9 years ago

File Screenshot from 2016-04-19 07-50-22.png Screenshot from 2016-04-19 07-50-22.png added
Status changed from New to Need more information

How are you changing the username? The input box is disabled.

Actions

Copy link

Updated by Brad Buckingham almost 9 years ago

Status changed from Need more information to New
Priority changed from Normal to Low

The user has Administrator role; therefore, the username is editable. If he attempts to update it, there is no error displayed; however, it seems that the user is logged out immediately and the change is not applied. Ideally, the field should be read-only or the user should see an error.

Actions

Copy link

Updated by Dominic Cleal almost 9 years ago

Subject changed from WebUI - no error on updating own username to blank to No error when updating own username to blank
Category set to Web Interface

The reason the username field is disabled in my screenshot is that it's incorrectly made disabled when the username is 'admin'.

Actions

Copy link

Updated by The Foreman Bot almost 9 years ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/3483 added

Actions

Copy link

Updated by Daniel Lobato Garcia almost 9 years ago

I think the actual issue is that we're filtering the 'login' parameter on the controller, so the request to update the login to ' ' is never fulfilled if you're editing your own user.

More info in the PR: https://github.com/theforeman/foreman/pull/3483#issuecomment-218388480

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Subject changed from No error when updating own username to blank to Unable to change own username through web UI
Status changed from Ready For Testing to New
Pull request deleted (~~https://github.com/theforeman/foreman/pull/3483~~)

PR closed due to inactivity, seems valid still.

Actions

Copy link

Updated by Daniel Gagnon about 8 years ago

This is still an issue on latest production release. Unable to rename any user. No errors are generated, but the change does not go through.

Actions

Copy link

Updated by Rahul Bajaj almost 8 years ago

I am a new contributor to this project and wish to work on this bug. Is this bug still valid ?

Actions

Copy link

Updated by Rahul Bajaj almost 8 years ago

Assignee set to Rahul Bajaj

Actions

Copy link

#10

Updated by Rahul Bajaj almost 8 years ago

I am analyzing a senario - An admin is unable to change his username but he can change other users name. The other users have the option to change their own user names but after updating the form it does not actually update thier usernames.

I have also raised a ticket regarding this issue : http://projects.theforeman.org/issues/19946

I am confused to whether what is the solution to this issue: either
1) Should all the users be restricted from updating their respective usernames ? OR
2) Should they be allowed ?

Actions

Copy link

#11

Updated by Daniel Lobato Garcia almost 8 years ago

Rahul, No need for a new ticket.

About your question, I think it would be a mix of both:

Users can update their own names if the Auth Source of these users is Internal, but cannot update their own names if the Auth Source is LDAP-based. The reason is simply that they'll lock themselves out if they change the name (Foreman won't propagate these changes to LDAP).

Actions

Copy link

#12