Bug #19448: After marking discovered hosts notification as read, new discovered host don't create notification - Discovery - Foreman

Actions

#1

Updated by Ohad Levy almost 8 years ago

Status changed from New to Feedback

for the record, it does update the expiry ts of the notification. I'm in mixed feelings if we should update the read or not?

Actions

Copy link

#2

Updated by Tomer Brisker almost 8 years ago

IMHO think we should - if you marked discovered hosts as read, then a new host gets discovered, you'd want to get notified about that.

Actions

Copy link

#3

Updated by Marek Hulán almost 8 years ago

Status changed from Feedback to New
Target version changed from Discovery Plugin 9.1.0 to Discovery Plugin 12.0.0

I'm reopening this, I think people should be notified about newly discovered hosts even if they marked notification about some discovered hosts previously as read. If people are generally not interested in some kind of notification, is there a way to disable it? Something like "do not notify me in future?". Since 9.1.0 was released already, I'm resetting the target version.

Actions

Copy link

#4

Updated by Ohad Levy over 7 years ago

if there is a common understanding this should happen for all kind of notifications, you might need to change it in core:
https://github.com/theforeman/foreman/blob/develop/app/models/notification_blueprint.rb#L20

Actions

Copy link

#5

Updated by The Foreman Bot over 7 years ago

Status changed from New to Ready For Testing
Assignee set to Tomer Brisker
Pull request https://github.com/theforeman/foreman_discovery/pull/377 added