Project

General

Custom queries

Profile

Actions

Bug #8442

closed

Eager loading on audits page does not work

Added by Ohad Levy over 10 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Database
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

ActiveRecord::EagerLoadPolymorphicError
Can not eagerly load the polymorphic association :user
app/views/audits/_list.html.erb:1:in `_53d8a19f5b9e17a52dbbf2112ae4186e'
app/views/audits/index.html.erb:3:in `_cde286859771808c11fbbbdf6d2f4212'
app/models/concerns/foreman/thread_session.rb:33:in `clear_thread'
lib/middleware/catch_json_parse_errors.rb:9:in `call'

Related issues 1 (0 open1 closed)

Related to Foreman - Bug #8425: n+1 query on audits indexClosedDaniel Lobato Garcia11/17/2014Actions
Actions #5

Updated by Joseph Magen over 10 years ago

  • Status changed from Ready For Testing to Closed

merged and changed commit msg to fixes #8442 - add eager loading of users on audit show page for history tab

Actions #6

Updated by Shlomi Zadok over 10 years ago

  • Status changed from Closed to New

Weird enough, https://github.com/theforeman/foreman/pull/1953/files and https://github.com/theforeman/foreman/pull/1964 should have cover this issue (which was tested by Ori and me) and now there is a regression.
re-opening (and fixing...)

Actions #7

Updated by Shlomi Zadok over 10 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2040 added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/1964)
Actions

Also available in: Atom PDF