Project

General

Profile

Actions

Bug #9812

closed

'match' and 'value' parameters in override value's create should be required in apidoc

Added by Martin Bacovsky over 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
API
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Currently it allows CLI to attempt to create override value without these params which result in 500.

[ INFO 2015-03-18 16:00:34 API] POST /api/smart_variables/205/override_values
[DEBUG 2015-03-18 16:00:34 API] Params: {
    "override_value" => {}
}
[DEBUG 2015-03-18 16:00:34 API] Headers: {}
[DEBUG 2015-03-18 16:00:35 API] 500 Internal Server Error
{
    "error" => {
        "message" => "undefined method `match' for nil:NilClass" 
    }
}


Related issues 3 (0 open3 closed)

Related to Foreman - Bug #10528: Can't save a smart class parameter/smart variable with the value 'false'ClosedTom Caspy05/17/2015Actions
Related to Foreman - Bug #9187: Overrideable empty puppet class parameters are still validate their default valueClosedOri Rabin02/02/2015Actions
Related to Foreman - Bug #11663: Empty lookup value validated even when use_puppet_default is checkedClosedOri Rabin09/02/2015Actions
Actions #1

Updated by Tomáš Strachota over 9 years ago

Not only they should be required in the docs but we must make sure the api can cope with the missing parameters and not to fail with 500.

Actions #2

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2255 added
  • Pull request deleted ()
Actions #3

Updated by Shlomi Zadok about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Dominic Cleal about 9 years ago

  • Assignee set to Shlomi Zadok
  • Translation missing: en.field_release set to 35
Actions #5

Updated by Dominic Cleal about 9 years ago

  • Related to Bug #10528: Can't save a smart class parameter/smart variable with the value 'false' added
Actions #6

Updated by Dominic Cleal about 9 years ago

  • Related to Bug #9187: Overrideable empty puppet class parameters are still validate their default value added
Actions #7

Updated by Dominic Cleal almost 9 years ago

  • Related to Bug #11663: Empty lookup value validated even when use_puppet_default is checked added
Actions

Also available in: Atom PDF