Refactor #14178

Replace jnotify with patternfly toast notifications

Added by Tomer Brisker about 2 years ago. Updated 6 months ago.

Status:Closed
Priority:Normal
Assigned To:matan werbner
Category:Web Interface
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4469
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

jQuery.jnotify has been dead for a couple of years. We should replace it with Patternfly Toast Notifications


Related issues

Related to Foreman - Bug #6865: Error notifications should not be popped up on top menus Rejected 07/31/2014
Related to Foreman - Bug #15137: Error notification stopped to show after going to the sam... Closed 05/23/2016
Related to Foreman - Feature #4629: Add Patternfly support in foreman Closed 03/11/2014
Related to Foreman - Bug #19490: remove apache license Closed 05/09/2017
Duplicated by Foreman - Refactor #16292: move jnotify from vendor to npm Duplicate 08/25/2016
Blocks Bastion - Feature #17990: Use foreman's toast notification instead of inline bst-alert Closed 01/09/2017
Blocks Katello - Refactor #18288: Updates to katello to use foreman toast notifications ins... Closed 01/27/2017

Associated revisions

Revision d91a0e4d
Added by Ohad Levy 12 months ago

fixes #14178 - introduce patternfly toast notifications

- replaces old jnoitfy with react implementation.
- Adds a notification store to handle events from
rails flash + legacy javascript Notice function and expose
an Action API to add notifications.

Revision 3186c78d
Added by Gail Steiger 12 months ago

fixes #14178 - introduce react patternfly toasts

Revision 68cd4bba
Added by matanw 12 months ago

fixes #14178 - Introduce patternfly toast notifications

Revision 37cb517c
Added by Dominic Cleal 12 months ago

refs #14178 - add uuid dependency

History

#1 Updated by Tomer Brisker about 2 years ago

  • Related to Bug #6865: Error notifications should not be popped up on top menus added

#2 Updated by Gail Steiger almost 2 years ago

  • Assigned To set to Gail Steiger

#3 Updated by Tomer Brisker almost 2 years ago

  • Related to Bug #15137: Error notification stopped to show after going to the same page added

#4 Updated by Daniel Lobato Garcia almost 2 years ago

Two places where these show up are when changing a setting to an invalid value on /settings, or when some action is done that modifies the /dashboard

#5 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4007 added

#6 Updated by Ohad Levy over 1 year ago

  • Related to Feature #4629: Add Patternfly support in foreman added

#7 Updated by Liza Gilman over 1 year ago

  • Assigned To changed from Gail Steiger to Liza Gilman

#8 Updated by Walden Raines about 1 year ago

  • Blocks Feature #17990: Use foreman's toast notification instead of inline bst-alert added

#9 Updated by Walden Raines about 1 year ago

  • Blocks Refactor #18288: Updates to katello to use foreman toast notifications instead of bst-alert added

#10 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/4300 added

#11 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/4469 added

#12 Updated by Ohad Levy 12 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#13 Updated by Tomer Brisker 12 months ago

  • Assigned To changed from Liza Gilman to matan werbner
  • Pull request deleted (https://github.com/theforeman/foreman/pull/4300, https://github.com/theforeman/foreman/pull/4007)

#14 Updated by Dominic Cleal 12 months ago

#15 Updated by Dominic Cleal 12 months ago

  • Related to Bug #19490: remove apache license added

#16 Updated by Marek Hulán 6 months ago

  • Release set to 1.16.0

Also available in: Atom PDF